7 Commits

Author SHA1 Message Date
Andrew Gillham
b1a43e57c7 Update device profile clockspeed.
The Mega also runs as 16MHz so update device.clockspeed to match.
2013-01-28 11:15:16 -08:00
Andrew Gillham
1f418098b2 Update device profile clockspeed & portdelay.
Set clock speed to 16MHz.  Hopefully this value works fine with the
client since the previous 100MHz was not the actual clockspeed anyway.
Also, adjust the device.open.portdelay to 1500ms.  People can test
their own device for the fastest value, but this should be a safer
default for most people and hopefully eliminates som frustration for
first time users.
2013-01-28 11:12:07 -08:00
Andrew Gillham
34aea7435d Update device profiles.
Add the 'device.receive.timeout' values required by the latest
LogicSniffer client application.
2013-01-28 10:58:23 -08:00
Andrew Gillham
f51d0bbb96 Improve pre-trigger sampling on below 500kHz sample rates.
The sample loop was not padded properly in the loop waiting for the
trigger to fire. As a result it was sampling at a much higher rate than
the post trigger sample rate.  I've added some delays and padded it out
a bit, it needs further measurement, but is usable now.
2012-02-27 14:36:17 -08:00
gillham
3a6329775c Merge pull request #3 from scottp/master
Correct long standing bug in the device profiles on github where the data was being reversed by the client due to the reverseOrder setting.  The sketch returns the data in the sampled order, but the client appears to expect it reversed, so the sense of the setting is backwards. Data is in the correct order based on a simple test program, even though the setting is "wrong".  Invert the comment as well.  Also increase the delay on the Mega as it doesn't always respond fast enough. Patches from scottp.
2012-02-27 12:27:45 -08:00
Scott Penrose
3c69ec10a1 ols.profile-*: Reverse IO order received in config
Fixed reverseOrder and comments

As per this post:
http://dangerousprototypes.com/forum/viewtopic.php?f=57&t=2432

The comment talking about device.samples.reverseOrder is reversed. I have
fixed the order and the comment and tested.
2012-02-03 15:57:04 +11:00
Scott Penrose
7173e83e14 ols.profile-aglam.cfg: Increased delay time
On testing a number of Arduino Mega boards, I found the device missing error.
Now it seems to be alwåays working if you set it to 2000.
2012-02-03 15:55:24 +11:00
4 changed files with 82 additions and 190 deletions

View File

@@ -25,7 +25,7 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* $Id: logic_analyzer.pde,v 1.17 2011-08-04 02:31:01 gillham Exp $
* $Id: logic_analyzer.ino,v 1.21 2012/02/27 20:19:44 gillham Exp $
*
*/
@@ -102,31 +102,20 @@ void debugdump(void);
* Uncomment CHAN5 to use it as an additional input on a normal Arduino.
* You'll need to change the number of channels in the device profile as well.
*
* Uncomment MEGARAM if you have an Arduino Mega with an external SRAM board with
* at least 64KB on it.
*
* Arduino device profile: ols.profile-agla.cfg
* Arduino Mega device profile: ols.profile-aglam.cfg
* Arduino Mega RAM device profile: ols.profile-aglamr.cfg
*/
#define MEGARAM 1
#if defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
#define DEBUGPORT PORTH
#define DEBUGDDR DDRH
#define CHANPIN PINF
#define CHAN0 A0
#define CHAN1 A1
#define CHAN2 A2
#define CHAN3 A3
#define CHAN4 A4
#define CHAN5 A5
#define CHAN6 A6
#define CHAN7 A7
#define CHANPIN PINA
#define CHAN0 22
#define CHAN1 23
#define CHAN2 24
#define CHAN3 25
#define CHAN4 26
#define CHAN5 27
#define CHAN6 28
#define CHAN7 29
#else
#define DEBUGPORT PORTD
#define DEBUGDDR DDRD
#define CHANPIN PINB
#define CHAN0 8
#define CHAN1 9
@@ -158,28 +147,19 @@ void debugdump(void);
#define SUMP_SELF_TEST 0x03
#define SUMP_GET_METADATA 0x04
/*
* Default capture buffer sizes. Lower values should work, but the metadata and/or
* device profiles will need to be adjusted to match.
* ATmega168: 532
* ATmega328: 1024 (1KB)
* ATmega2560: 7168 (7KB)
* ATmega2560+external SRAM: 56320 (55KB)
/* ATmega168: 532 (or lower)
* ATmega328: 1024 (or lower)
* ATmega2560: 7168 (or lower)
*/
#if defined(MEGARAM)
#define DEBUG_CAPTURE_SIZE 56320
#define CAPTURE_SIZE 56320
#elif defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
#define DEBUG_CAPTURE_SIZE 7168
#define CAPTURE_SIZE 7168
#if defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
#define DEBUG_CAPTURE_SIZE 7168
#define CAPTURE_SIZE 7168
#elif defined(__AVR_ATmega328P__)
#define DEBUG_CAPTURE_SIZE 1024
#define CAPTURE_SIZE 1024
#define DEBUG_CAPTURE_SIZE 1024
#define CAPTURE_SIZE 1024
#else
#define DEBUG_CAPTURE_SIZE 532
#define CAPTURE_SIZE 532
#define DEBUG_CAPTURE_SIZE 532
#define CAPTURE_SIZE 532
#endif
#define DEBUG
@@ -201,20 +181,7 @@ byte savebytes[128];
int savecount = 0;
#endif /* DEBUG */
/*
* External SRAM adds 56,320 (55kb) directly addressable bytes starting at 0x2200.
* We access it via a hard coded pointer instead of a directly allocated array like
* on other Arduinos.
*
* We only use bank 0 as our capture routines can't spare the cycles to switch banks.
*
*/
#ifdef MEGARAM
byte *logicdata = (byte *) 0x2200U;
#else
byte logicdata[MAX_CAPTURE_SIZE];
#endif
unsigned int logicIndex = 0;
unsigned int triggerIndex = 0;
unsigned int readCount = MAX_CAPTURE_SIZE;
@@ -227,17 +194,6 @@ unsigned long divider = 0;
void setup()
{
#ifdef MEGARAM
XMCRA = _BV(SRE); // Enable external memory interface
pinMode(38, OUTPUT); digitalWrite(38, LOW); // Enable RAM device
pinMode(42, OUTPUT); // Make the bank selection bits output pins
pinMode(43, OUTPUT); // Make the bank selection bits output pins
pinMode(44, OUTPUT); // Make the bank selection bits output pins
digitalWrite(42, LOW); // Select bank 0 (see below for discussion)
digitalWrite(43, LOW); // Select bank 0 (see below for discussion)
digitalWrite(44, LOW); // Select bank 0 (see below for discussion)
#endif // MEGARAM
Serial.begin(115200);
/*
@@ -246,7 +202,7 @@ void setup()
* the sample time. this is used during development to
* properly pad out the sampling routines.
*/
DEBUGDDR = DEBUGDDR | B10000000; /* debug measurement pin */
DDRD = DDRD | B10000000; /* debug measurement pin */
pinMode(CHAN0, INPUT);
pinMode(CHAN1, INPUT);
@@ -269,7 +225,7 @@ void setup()
void loop()
{
unsigned int i;
int i;
if (Serial.available() > 0) {
cmdByte = Serial.read();
@@ -412,12 +368,6 @@ void loop()
*/
debugdump();
break;
case '3':
/*
* This samples the channel pin and writes to the serial port. Used for debugging.
*/
Serial.print(CHANPIN, HEX);
break;
#endif /* DEBUG */
default:
/* ignore any unrecognized bytes. */
@@ -475,7 +425,7 @@ void getCmd() {
*/
void captureMicro() {
unsigned int i;
int i;
/*
* basic trigger, wait until all trigger conditions are met on port B.
@@ -499,14 +449,14 @@ void captureMicro() {
* any timing unexpectedly.
* Arduino pin 7 is being used here.
*/
DEBUGDDR = DEBUGDDR | B10000000;
DEBUGPORT = B10000000;
DDRD = DDRD | B10000000;
PORTD = B10000000;
delayMicroseconds(20);
DEBUGPORT = B00000000;
PORTD = B00000000;
delayMicroseconds(20);
DEBUGPORT = B10000000;
PORTD = B10000000;
delayMicroseconds(20);
DEBUGPORT = B00000000;
PORTD = B00000000;
delayMicroseconds(20);
if (delayTime == 1) {
@@ -514,34 +464,30 @@ void captureMicro() {
* 1MHz sample rate = 1 uS delay so we can't use delayMicroseconds
* since our loop takes some time. The delay is padded out by hand.
*/
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
for (i = 0 ; i < readCount; i++) {
logicdata[i] = CHANPIN;
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
#endif /* MEGARAM */
}
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
}
else if (delayTime == 2) {
/*
* 500KHz sample rate = 2 uS delay, still pretty fast so we pad this
* one by hand too.
*/
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
for (i = 0 ; i < readCount; i++) {
logicdata[i] = CHANPIN;
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
#endif /* MEGARAM */
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
}
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
}
else {
/*
@@ -550,15 +496,13 @@ void captureMicro() {
* a better logic analyzer)
* start of real measurement
*/
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
for (i = 0 ; i < readCount; i++) {
logicdata[i] = CHANPIN;
delayMicroseconds(delayTime - 1);
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t");
#endif /* MEGARAM */
}
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
}
/* re-enable interrupts now that we're done sampling. */
@@ -591,7 +535,7 @@ void captureMicro() {
* this basic functionality.
*/
void captureMilli() {
unsigned int i;
int i;
/*
* very basic trigger, just like in captureMicros() above.
@@ -618,7 +562,7 @@ void captureMilli() {
*
*/
void triggerMicro() {
unsigned int i = 0;
int i = 0;
logicIndex = 0;
triggerIndex = 0;
@@ -637,14 +581,14 @@ void triggerMicro() {
* any timing unexpectedly.
* Arduino pin 7 is being used here.
*/
DEBUGDDR = DEBUGDDR | B10000000;
DEBUGPORT = B10000000;
DDRD = DDRD | B10000000;
PORTD = B10000000;
delayMicroseconds(20);
DEBUGPORT = B00000000;
PORTD = B00000000;
delayMicroseconds(20);
DEBUGPORT = B10000000;
PORTD = B10000000;
delayMicroseconds(20);
DEBUGPORT = B00000000;
PORTD = B00000000;
delayMicroseconds(20);
if (delayTime == 1) {
@@ -669,9 +613,9 @@ void triggerMicro() {
* we always start capturing at the start of the buffer
* and use it as a circular buffer
*/
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
while ((trigger_values ^ (logicdata[logicIndex] = CHANPIN)) & trigger) {
/* DEBUGPORT = B00000000; */
/* PORTD = B00000000; */
/* increment index. */
logicIndex++;
if (logicIndex >= readCount) {
@@ -682,16 +626,12 @@ void triggerMicro() {
* without pin toggles, will try 1 nop.
* __asm__("nop\n\t""nop\n\t""nop\n\t");
*/
#ifndef MEGARAM
__asm__("nop\n\t");
#endif /* MEGARAM */
/* DEBUGPORT = B10000000; */
/* PORTD = B10000000; */
}
/* this pads the immediate trigger case to 2.0 uS, just as an example. */
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
#endif /* MEGARAM */
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
/*
* One sample size delay. ends up being 2 uS combined with assignment
@@ -699,16 +639,14 @@ void triggerMicro() {
* between the trigger point and the subsequent samples.
*/
delayMicroseconds(1);
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
#endif /* MEGARAM */
/* 'logicIndex' now points to trigger sample, keep track of it */
triggerIndex = logicIndex;
/* keep sampling for delayCount after trigger */
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
/*
* this is currently taking:
* 1025.5 uS for 512 samples. (512 samples, 0/100 split)
@@ -719,13 +657,11 @@ void triggerMicro() {
logicIndex = 0;
}
logicdata[logicIndex++] = CHANPIN;
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
#endif /* MEGARAM */
}
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
delayMicroseconds(100);
}
else {
@@ -738,17 +674,23 @@ void triggerMicro() {
* and use it as a circular buffer
*
*/
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
while ((trigger_values ^ (logicdata[logicIndex] = CHANPIN)) & trigger) {
/* DEBUGPORT = B00000000; */
/* PORTD = B00000000; */
/* increment index. */
logicIndex++;
if (logicIndex >= readCount) {
logicIndex = 0;
}
/* DEBUGPORT = B10000000; */
else {
/* pad the same number of cycles as the above assignment (needs verification) */
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
}
delayMicroseconds(delayTime - 3);
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t""nop\n\t");
/* PORTD = B10000000; */
}
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
/* 'logicIndex' now points to trigger sample, keep track of it */
triggerIndex = logicIndex;
@@ -757,23 +699,24 @@ void triggerMicro() {
* This needs adjustment so that we have the right spacing between the
* before trigger samples and the after trigger samples.
*/
delayMicroseconds(delayTime);
delayMicroseconds(delayTime - 2);
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t");
/* keep sampling for delayCount after trigger */
DEBUGPORT = B10000000; /* debug timing measurement */
PORTD = B10000000; /* debug timing measurement */
for (i = 0 ; i < delayCount; i++) {
if (logicIndex >= readCount) {
logicIndex = 0;
}
logicdata[logicIndex++] = CHANPIN;
delayMicroseconds(delayTime - 3);
#ifndef MEGARAM
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
#endif /* MEGARAM */
__asm__("nop\n\t""nop\n\t""nop\n\t""nop\n\t");
__asm__("nop\n\t""nop\n\t""nop\n\t");
}
DEBUGPORT = B00000000; /* debug timing measurement */
PORTD = B00000000; /* debug timing measurement */
delayMicroseconds(100);
}
@@ -838,9 +781,6 @@ void get_metadata() {
#if defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
Serial.write('M');
#endif /* Mega */
#if defined(MEGARAM)
Serial.write('R');
#endif /* MEGARAM */
Serial.write('v');
Serial.write('0');
Serial.write((uint8_t)0x00);
@@ -849,16 +789,12 @@ void get_metadata() {
Serial.write((uint8_t)0x21);
Serial.write((uint8_t)0x00);
Serial.write((uint8_t)0x00);
#if defined(MEGARAM)
/* 56320 bytes (55KB) */
Serial.write((uint8_t)0xDC);
Serial.write((uint8_t)0x00);
#elif defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
/* 7168 bytes (7KB) */
#if defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
/* 7168 bytes */
Serial.write((uint8_t)0x1C);
Serial.write((uint8_t)0x00);
#elif defined(__AVR_ATmega328P__)
/* 1024 bytes (1KB) */
/* 1024 bytes */
Serial.write((uint8_t)0x04);
Serial.write((uint8_t)0x00);
#else
@@ -939,7 +875,7 @@ void debugprint() {
* of the sample buffer.
*/
void debugdump() {
unsigned int i;
int i;
int j = 1;
Serial.print("\r\n");
@@ -957,3 +893,6 @@ void debugdump() {
#endif /* DEBUG */

View File

@@ -7,7 +7,7 @@ device.description = Arduino Generic Logic Analyzer
# The device interface, SERIAL only
device.interface = SERIAL
# The device's native clockspeed, in Hertz.
device.clockspeed = 100000000
device.clockspeed = 16000000
# Whether or not double-data-rate is supported by the device (also known as the "demux"-mode).
device.supports_ddr = false
# Supported sample rates in Hertz, separated by comma's
@@ -39,13 +39,15 @@ device.capturesize.bound = false
device.channel.numberingschemes = DEFAULT
# Is a delay after opening the port and device detection needed? (0 = no delay, >0 = delay in milliseconds)
device.open.portdelay = 500
device.open.portdelay = 1500
# The receive timeout for the device (in milliseconds, 100 = default, <=0 = no timeout)
device.receive.timeout = 100
# Does the device need a high or low DTR-line to operate correctly? (high = true, low = false)
device.open.portdtr = true
# Which metadata keys correspond to this device profile? Value is a comma-separated list of (double quoted) names...
device.metadata.keys = "AGLAv0"
# In which order are samples sent back from the device? true = last sample first, false = first sample first
device.samples.reverseOrder = false
# In which order are samples sent back from the device? false = last sample first, true = first sample first
device.samples.reverseOrder = true
###EOF###

View File

@@ -7,7 +7,7 @@ device.description = Arduino Mega Logic Analyzer
# The device interface, SERIAL only
device.interface = SERIAL
# The device's native clockspeed, in Hertz.
device.clockspeed = 100000000
device.clockspeed = 16000000
# Whether or not double-data-rate is supported by the device (also known as the "demux"-mode).
device.supports_ddr = false
# Supported sample rates in Hertz, separated by comma's
@@ -39,13 +39,15 @@ device.capturesize.bound = false
device.channel.numberingschemes = DEFAULT
# Is a delay after opening the port and device detection needed? (0 = no delay, >0 = delay in milliseconds)
device.open.portdelay = 1000
device.open.portdelay = 2000
# The receive timeout for the device (in milliseconds, 100 = default, <=0 = no timeout)
device.receive.timeout = 100
# Does the device need a high or low DTR-line to operate correctly? (high = true, low = false)
device.open.portdtr = true
# Which metadata keys correspond to this device profile? Value is a comma-separated list of (double quoted) names...
device.metadata.keys = "AGLAMv0"
# In which order are samples sent back from the device? true = last sample first, false = first sample first
device.samples.reverseOrder = false
# In which order are samples sent back from the device? false = last sample first, true = first sample first
device.samples.reverseOrder = true
###EOF###

View File

@@ -1,51 +0,0 @@
# Configuration for Arduino MegaRAM Logic Analyzer profile
# The short (single word) type of the device described in this profile
device.type = AGLAMR
# A longer description of the device
device.description = Arduino MegaRAM Logic Analyzer
# The device interface, SERIAL only
device.interface = SERIAL
# The device's native clockspeed, in Hertz.
device.clockspeed = 100000000
# Whether or not double-data-rate is supported by the device (also known as the "demux"-mode).
device.supports_ddr = false
# Supported sample rates in Hertz, separated by comma's
device.samplerates = 10, 20, 50, 100, 200, 500, 1000, 2000, 5000, 10000, 20000, 50000, 100000, 200000, 500000, 1000000
# What capture clocks are supported
device.captureclock = INTERNAL
# The supported capture sizes, in bytes
device.capturesizes = 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384, 32768, 56320
# Whether or not the noise filter is supported
device.feature.noisefilter = false
# Whether or not Run-Length encoding is supported
device.feature.rle = false
# Whether or not a testing mode is supported
device.feature.testmode = false
# Whether or not triggers are supported
device.feature.triggers = true
# The number of trigger stages
device.trigger.stages = 1
# Whether or not "complex" triggers are supported
device.trigger.complex = false
# The total number of channels usable for capturing
device.channel.count = 8
# The number of channels groups, together with the channel count determines the channels per group
device.channel.groups = 1
# Whether the capture size is limited by the enabled channel groups
device.capturesize.bound = false
# Which numbering does the device support
device.channel.numberingschemes = DEFAULT
# Is a delay after opening the port and device detection needed? (0 = no delay, >0 = delay in milliseconds)
device.open.portdelay = 1000
# Does the device need a high or low DTR-line to operate correctly? (high = true, low = false)
device.open.portdtr = true
# Which metadata keys correspond to this device profile? Value is a comma-separated list of (double quoted) names...
device.metadata.keys = "AGLAMRv0"
# In which order are samples sent back from the device? true = last sample first, false = first sample first
device.samples.reverseOrder = false
###EOF###