catarrh/pysim
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/pysim.git synced 2026-03-17 02:48:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 11

Browse Source 
Patch Set 11:

(4 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000005
2026-03-15 22:40:05 +00:00
committed by Gerrit Code Review
parent 048f06e2b3
commit 80e622dd14
1 changed files with 72 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
7886e59f82c71cc40c1040c6712e60cdf91f4f45
View File

@@ -34,6 +34,24 @@
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "0f6ea6c7_7c4edfa6",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 209,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "if you mean the triple single quotes -- AFAIK *any* string format in this location is a docstring. Though laforge has indicated that i sould follow the triple double quote convention.",
"parentUuid": "37303680_0841eeb4",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -51,6 +69,24 @@
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "077471e9_e2401188",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 290,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "Done",
"parentUuid": "df8adf24_6dd87150",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -68,6 +104,24 @@
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "a27f69de_37436e9b",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 292,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "the values are coming from a ProfileElementSequence\u0027s decoded section, should always be either a hexstr or bytes. ok?",
"parentUuid": "7ddc4bfe_68a1a8c5",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -84,6 +138,24 @@
"message": "You are sure that you want to turn val to ascii, like \"4141\" \u003d\u003e \"AA\"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "8184e5b7_69812655",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 297,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "I got this code from elsewhere (or reversing code from elsewhere?)\nand I am positively sure that it works as intended.\n\nthis is how PIN and PUK are stored, apparently actually the ascii codes of the PIN/PUK digits. The function makes a PIN/PUK human readable.\n\nThe only reason to not directly do a .decode(\u0027ascii\u0027) is apparently the rpad / unrpad.",
"parentUuid": "501ac867_7f438d57",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}