mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-03-16 18:38:32 +03:00
Compare commits
9 Commits
048f06e2b3
...
d4ef07bce7
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d4ef07bce7 | ||
|
|
ce1d55a243 | ||
|
|
b23521440b | ||
|
|
98780481b8 | ||
|
|
0360250697 | ||
|
|
4649292c5d | ||
|
|
d080c6c50c | ||
|
|
e145e0371e | ||
|
|
80e622dd14 |
21
1e31f34cc212a026f2355159851c33d252f9e82d
Normal file
21
1e31f34cc212a026f2355159851c33d252f9e82d
Normal file
@@ -0,0 +1,21 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "36200753_75b6b704",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 12
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-15T22:41:07Z",
|
||||
"side": 1,
|
||||
"message": "(re-applying earlier +2 after trivial changes)",
|
||||
"revId": "1e31f34cc212a026f2355159851c33d252f9e82d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
@@ -34,6 +34,24 @@
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0f6ea6c7_7c4edfa6",
|
||||
"filename": "pySim/esim/saip/personalization.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 209,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-15T22:40:05Z",
|
||||
"side": 1,
|
||||
"message": "if you mean the triple single quotes -- AFAIK *any* string format in this location is a docstring. Though laforge has indicated that i sould follow the triple double quote convention.",
|
||||
"parentUuid": "37303680_0841eeb4",
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -51,6 +69,24 @@
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "077471e9_e2401188",
|
||||
"filename": "pySim/esim/saip/personalization.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 290,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-15T22:40:05Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "df8adf24_6dd87150",
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -68,6 +104,24 @@
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "a27f69de_37436e9b",
|
||||
"filename": "pySim/esim/saip/personalization.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 292,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-15T22:40:05Z",
|
||||
"side": 1,
|
||||
"message": "the values are coming from a ProfileElementSequence\u0027s decoded section, should always be either a hexstr or bytes. ok?",
|
||||
"parentUuid": "7ddc4bfe_68a1a8c5",
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -84,6 +138,24 @@
|
||||
"message": "You are sure that you want to turn val to ascii, like \"4141\" \u003d\u003e \"AA\"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)",
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "8184e5b7_69812655",
|
||||
"filename": "pySim/esim/saip/personalization.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 297,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-15T22:40:05Z",
|
||||
"side": 1,
|
||||
"message": "I got this code from elsewhere (or reversing code from elsewhere?)\nand I am positively sure that it works as intended.\n\nthis is how PIN and PUK are stored, apparently actually the ascii codes of the PIN/PUK digits. The function makes a PIN/PUK human readable.\n\nThe only reason to not directly do a .decode(\u0027ascii\u0027) is apparently the rpad / unrpad.",
|
||||
"parentUuid": "501ac867_7f438d57",
|
||||
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user