Compare commits

...

9 Commits

Author SHA1 Message Date
Gerrit User 1000002
d4ef07bce7 Update patch set 13
Patch-set: 13
Reviewer: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
2026-03-15 22:58:30 +00:00
Gerrit User 1000002
ce1d55a243 Update patch set 12
Patch Set 12: Verified-1

1 failed:
* [pylint] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=pylint,a1=default,a3=default,a4=default,label=osmocom-gerrit/2934/consoleFull

4 passed:
* [distcheck] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=distcheck,a1=default,a3=default,a4=default,label=osmocom-gerrit/2934/consoleFull
* [docs] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=docs,a1=default,a3=default,a4=default,label=osmocom-gerrit/2934/consoleFull
* [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27487/consoleFull
* [test] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=test,a1=default,a3=default,a4=default,label=simtester/2934/consoleFull

Build Failed

Find the Retrigger button here:
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2941/

Patch-set: 12
Tag: jenkins
Label: Verified=-1, ca60f976c9536e4cbf48a65b788d38bd2193a348
2026-03-15 22:58:30 +00:00
Gerrit User 1000002
b23521440b Update patch set 13
Patch Set 13:

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2945/consoleFull

Patch-set: 13
Tag: jenkins
2026-03-15 22:53:19 +00:00
Gerrit User 1000005
98780481b8 Create patch set 13
Uploaded patch set 13: Patch Set 12 was rebased.

Copied Votes:
* Code-Review+2 (copy condition: "changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN")


Patch-set: 13
Subject: personalization: implement reading back values from a PES
Commit: 1e0b3b35d4
Tag: autogenerated:gerrit:newPatchSet
Groups: ee0853a149
Copied-Label: Code-Review=+2, 2eae9000dac4ed7df727466ccd77b2911236126a Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
2026-03-15 22:52:52 +00:00
Gerrit User 1000005
0360250697 Update patch set 12
Patch Set 12: Code-Review+2

(1 comment)

Patch-set: 12
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2, 2eae9000dac4ed7df727466ccd77b2911236126a
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
2026-03-15 22:41:07 +00:00
Gerrit User 1000002
4649292c5d Update patch set 12
Patch Set 12:

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2941/consoleFull

Patch-set: 12
Tag: jenkins
2026-03-15 22:40:50 +00:00
Gerrit User 1000005
d080c6c50c Create patch set 12
Uploaded patch set 12.

Outdated Votes:
* Code-Review+1, Code-Review+2 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN")
* Verified+1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE")


Patch-set: 12
Subject: personalization: implement reading back values from a PES
Commit: 1e31f34cc2
Tag: autogenerated:gerrit:newPatchSet
Groups: 3bfa6cc73f
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+2"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
2026-03-15 22:40:26 +00:00
Gerrit User 1000005
e145e0371e Update patch set 11
Patch Set 11: Code-Review+2

Patch-set: 11
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2, de576144aa048c008a9261ad56146112012d3028
2026-03-15 22:40:13 +00:00
Gerrit User 1000005
80e622dd14 Update patch set 11
Patch Set 11:

(4 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
2026-03-15 22:40:05 +00:00
2 changed files with 93 additions and 0 deletions

View File

@@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "36200753_75b6b704",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:41:07Z",
"side": 1,
"message": "(re-applying earlier +2 after trivial changes)",
"revId": "1e31f34cc212a026f2355159851c33d252f9e82d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

View File

@@ -34,6 +34,24 @@
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "0f6ea6c7_7c4edfa6",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 209,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "if you mean the triple single quotes -- AFAIK *any* string format in this location is a docstring. Though laforge has indicated that i sould follow the triple double quote convention.",
"parentUuid": "37303680_0841eeb4",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -51,6 +69,24 @@
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "077471e9_e2401188",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 290,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "Done",
"parentUuid": "df8adf24_6dd87150",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -68,6 +104,24 @@
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "a27f69de_37436e9b",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 292,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "the values are coming from a ProfileElementSequence\u0027s decoded section, should always be either a hexstr or bytes. ok?",
"parentUuid": "7ddc4bfe_68a1a8c5",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -84,6 +138,24 @@
"message": "You are sure that you want to turn val to ascii, like \"4141\" \u003d\u003e \"AA\"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "8184e5b7_69812655",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 11
},
"lineNbr": 297,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-15T22:40:05Z",
"side": 1,
"message": "I got this code from elsewhere (or reversing code from elsewhere?)\nand I am positively sure that it works as intended.\n\nthis is how PIN and PUK are stored, apparently actually the ascii codes of the PIN/PUK digits. The function makes a PIN/PUK human readable.\n\nThe only reason to not directly do a .decode(\u0027ascii\u0027) is apparently the rpad / unrpad.",
"parentUuid": "501ac867_7f438d57",
"revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}